gh-129173: refactor PyCodec_ReplaceErrors into separate functions
#129893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We also refactor that handler and extract the logic for each exceptions being handled into separate functions.
encukou
reviewed
Feb 24, 2025
AA-Turner
changed the title
replace handler.replace handler
encukou
reviewed
Feb 24, 2025
picnixz
changed the title
replace handlerPyCodec_ReplaceErrors into separate functions
seehwan
pushed a commit
to seehwan/cpython
that referenced
this pull request
Apr 16, 2025
…ions (python#129893) The logic of `PyCodec_ReplaceErrors` is now split into separate functions, each of which handling a specific exception type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We also refactor that handler and extract the logic for each exceptions being handled into separate functions.
_PyUnicodeError_GetParamsand extract complex logic into separate functions #129173