gh-130048: Reintroduce full LTO as default #130049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fidget-Spinner
requested review from
erlend-aasland and
corona10
as code owners
|
!buildbot clang |
|
🤖 New build scheduled with the buildbot fleet by @Fidget-Spinner for commit ef18a08 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
corona10
reviewed
Feb 13, 2025
There was a problem hiding this comment.
I leave comment at here
#130048 (comment)
But I am okay to revert it.
But the main reason should be the perf regression on many platform that are using clang, but not many people are not handle it properly, it would not be fair because it is always happen :) (and we still allow fullLTO if they want)
Or we could just revert the policy for the macOS but I prefer to revert all policy which will be clear
lazka
added a commit
to lazka/MINGW-packages
that referenced
this pull request
Feb 13, 2025
See python/cpython#130049 We also didn't notice
lazka
added a commit
to msys2/MINGW-packages
that referenced
this pull request
Feb 13, 2025
See python/cpython#130049 We also didn't notice
corona10
approved these changes
Feb 13, 2025
|
Thanks for the review, Dong-hee! |
Fidget-Spinner
added a commit
to Fidget-Spinner/cpython
that referenced
this pull request
Feb 13, 2025
…thonGH-130049)" This reverts commit 34c06cc.
Fidget-Spinner
added a commit
that referenced
this pull request
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially reverts e47b96c
📚 Documentation preview 📚: https://cpython-previews--130049.org.readthedocs.build/