Skip to content

gh-130605: Use relaxed atomics to set the GIL switch interval #130654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2025
Merged

gh-130605: Use relaxed atomics to set the GIL switch interval #130654

merged 1 commit into from
Feb 28, 2025

Conversation

colesbury
Copy link
Contributor

@colesbury colesbury commented Feb 27, 2025 •
edited by bedevere-app bot
Loading

The interval may be concurrently read by a thread attempting to acquire the GIL.

@colesbury
pythongh-130605: Use relaxed atomics to set the GIL switch interval
6ffac12 
The interval may be concurrently read by a thread attempting to acquire
the GIL.
@colesbury colesbury requested a review from mpage February 27, 2025 20:41
@bedevere-app bedevere-app bot mentioned this pull request Feb 27, 2025
Closed
vstinner
vstinner approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I cannot find other places accessing gil->interval.

@colesbury colesbury merged commit 038e4d6 into python:main Feb 28, 2025
49 checks passed
@colesbury colesbury deleted the gh-130605-set-switch-interval branch February 28, 2025 14:27
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
@colesbury @seehwan80
pythongh-130605: Use relaxed atomics to set the GIL switch interval (p…
fa274dd 
…ythongh-130654)

The interval may be concurrently read by a thread attempting to acquire
the GIL.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@mpage mpage mpage approved these changes

@corona10 corona10 corona10 approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@colesbury @vstinner @mpage @corona10