Skip to content

gh-130790: Remove references about unicode's readiness from comments #130801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sergey-miryanov
Copy link
Contributor

@sergey-miryanov sergey-miryanov commented Mar 3, 2025

And remove calls to PyUnicode_IS_READY

@sergey-miryanov
Copy link
Contributor Author

This is a style change that arose from @encukou #129894 (comment)

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner
Copy link
Member

vstinner commented Mar 3, 2025

I don't think that this change should be backported.

@picnixz
Copy link
Member

picnixz commented Mar 3, 2025

I'm fine with not backporting it (I'm afraid that there will conflicts since codecs.c changed but wasn't backported).

@vstinner vstinner enabled auto-merge (squash) March 3, 2025 19:02
@vstinner vstinner merged commit 3a7f17c into python:main Mar 3, 2025
41 checks passed
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants