-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-132097: remove unnecessary clinic casts to PyCFunction
and others
#131665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@vstinner This one is purely cosmetic but it affects lots of files. It's about removing redundant casts. I've removed some redundant casts with non-clinic files but this one just removes the casts generated by clinic. I'm not entirely sure I want to merge this for the following reason:
I'm going to first address the fastcall issue before continuing here so take your time. I won't commit if you're not happy with this change or if you prefer that we hold it until we see a real issue. |
PyCFunction
PyCFunction
and others
PyCFunction
and othersPyCFunction
and others
PyCFunction
and othersPyCFunction
and others
I more or less added explicit casts for WASM in #132406 so what's left here is just removing redundant casts. If someone wants to push for that, we'll do it but it will create conflicts in many generated files (which, thankfully, are easy to fix with |
-fsanitize=undefined -fno-sanitize-recover
#132097