Skip to content

gh-101410: revert loghelper() change in 75f59bb for integer input #132625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 17, 2025
Merged

gh-101410: revert loghelper() change in 75f59bb for integer input #132625

merged 2 commits into from
Apr 17, 2025

Conversation

skirpichev
Copy link
Member

@skirpichev skirpichev commented Apr 17, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Apr 17, 2025
Closed
@skirpichev skirpichev mentioned this pull request Apr 17, 2025
Merged
serhiy-storchaka
serhiy-storchaka approved these changes Apr 17, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (with minor suggestion for test).

@skirpichev @serhiy-storchaka
Update Lib/test/test_math.py
9a8d5f5 
Co-authored-by: Serhiy Storchaka <[email protected]>
@serhiy-storchaka serhiy-storchaka merged commit 0c356c8 into python:main Apr 17, 2025
41 checks passed
@skirpichev skirpichev deleted the fix-msg-loghelper/101410 branch April 17, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skirpichev @serhiy-storchaka