GH-130328: Speedup pasting in legacy console on Windows #133728
+26
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chris-eibl
commented
May 9, 2025
•
chris-eibl
commented
- Issue: Pasting in new REPL is slow #130328
chris-eibl
commented
May 9, 2025
| for i in range(rec_count): | ||
| rec = recs[i] | ||
| # In case of a legacy console, we do not only receive a keydown |
There was a problem hiding this comment.
Actually, there is a lot of duplicated logic from get_event now. Maybe refactor that, so the logic can be reused here?
chris-eibl
commented
May 9, 2025
| @@ -449,8 +442,11 @@ def get_event(self, block: bool = True) -> Event | None: | |||
| and there is no event pending, otherwise waits for the | |||
| completion of an event.""" | |||
|
|
|||
| if not block and not self.wait(timeout=0): | |||
There was a problem hiding this comment.
I have moved blocking and waiting logic into get_event like in unix_console.py. IMHO that shouldn't be part of reading and we're in perfect sync with Unix now.
chris-eibl
commented
May 9, 2025
| @@ -484,7 +491,6 @@ def do(self) -> None: | |||
| data = "" | |||
| start = time.time() | |||
| while done not in data: | |||
| self.reader.console.wait(100) | |||
There was a problem hiding this comment.
I don't think this is needed. Works for me without it. For both, Linux and Windows, this will immediately return in case of pending data, and just needlessly waits 100 ms if there is no more data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.