gh-85045: clarified that the underlying buffer of a TextIOBase can be a RawIOBase #134372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
bedevere-app
bot
added
docs
that the underlying binary buffer of a TextIOBase can be a BufferedIOBase OR a RawIOBase
AlexKautz
force-pushed
the
85045-io.TextIOBase.buffer-is-not-necessarily-a-buffer
branch
from
678ebbb to
169c954
Compare
gpshead
added
needs backport to 3.13
|
Thanks @AlexKautz for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 20, 2025
…can be a RawIOBase (pythonGH-134372) Added a clarification that the underlying binary buffer of a TextIOBase can be a BufferedIOBase OR a RawIOBase (cherry picked from commit 36eb711) Co-authored-by: Alex Kautz <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 20, 2025
…can be a RawIOBase (pythonGH-134372) Added a clarification that the underlying binary buffer of a TextIOBase can be a BufferedIOBase OR a RawIOBase (cherry picked from commit 36eb711) Co-authored-by: Alex Kautz <[email protected]>
|
GH-134374 is a backport of this pull request to the 3.14 branch. |
|
GH-134375 is a backport of this pull request to the 3.13 branch. |
gpshead
pushed a commit
that referenced
this pull request
May 20, 2025
… can be a RawIOBase (GH-134372) (#134374) gh-85045: clarified that the underlying buffer of a TextIOBase can be a RawIOBase (GH-134372) Added a clarification that the underlying binary buffer of a TextIOBase can be a BufferedIOBase OR a RawIOBase (cherry picked from commit 36eb711) Co-authored-by: Alex Kautz <[email protected]>
gpshead
pushed a commit
that referenced
this pull request
May 20, 2025
… can be a RawIOBase (GH-134372) (#134375) gh-85045: clarified that the underlying buffer of a TextIOBase can be a RawIOBase (GH-134372) Added a clarification that the underlying binary buffer of a TextIOBase can be a BufferedIOBase OR a RawIOBase (cherry picked from commit 36eb711) Co-authored-by: Alex Kautz <[email protected]>
lkollar
pushed a commit
to lkollar/cpython
that referenced
this pull request
May 26, 2025
…can be a RawIOBase (pythonGH-134372) Added a clarification that the underlying binary buffer of a TextIOBase can be a BufferedIOBase OR a RawIOBase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a clarification that the underlying binary buffer of a TextIOBase
can be a BufferedIOBase OR a RawIOBase.
RawIOBase was previously not specified because it is a edge case (was recently added along with non-buffered mode).
📚 Documentation preview 📚: https://cpython-previews--134372.org.readthedocs.build/