gh-132983: Fix refleak in zstd dictionary functions #134459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
|
Thanks @emmatyping for the PR, and @ericsnowcurrently for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 21, 2025
…34459) (cherry picked from commit fb68776) Co-authored-by: Emma Smith <[email protected]>
|
GH-134463 is a backport of this pull request to the 3.14 branch. |
ericsnowcurrently
pushed a commit
that referenced
this pull request
May 21, 2025
(cherry picked from commit fb68776, AKA gh-134459) Co-authored-by: Emma Smith <[email protected]>
|
Hah, I even looked at the original PR for a dealloc, guess I also missed that case. ❤️ |
lkollar
pushed a commit
to lkollar/cpython
that referenced
this pull request
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed deallocating the array of samples sizes if an invalid array of samples are provided. h/t to @ericsnowcurrently for spotting the buildbot failure.