Skip to content

bpo-36974: document PEP 590 #13450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jun 2, 2019
Merged

bpo-36974: document PEP 590 #13450

merged 14 commits into from
Jun 2, 2019

Conversation

jdemeyer
Copy link
Contributor

@jdemeyer jdemeyer commented May 20, 2019 •
edited by bedevere-bot
Loading

@jdemeyer jdemeyer force-pushed the pep590docs branch 2 times, most recently from ed48270 to d733a32 Compare May 21, 2019 09:20
@jdemeyer jdemeyer mentioned this pull request May 29, 2019
Merged
@encukou
Copy link
Member

encukou commented May 31, 2019

I'll work on updating the docs today.
@jdemeyer I'll push changes your branch directly, if you don't mind.

@encukou
Copy link
Member

encukou commented May 31, 2019

Rebased & updated

encukou added 2 commits June 3, 2019 00:12
@encukou
Clarify how vectorcall works with subclassing
d12fe1d 
This is not described in detail in PEP 590;
see python#13699
for the practical issue.
@encukou
Fix ReST syntax
e785520
@encukou encukou marked this pull request as ready for review June 2, 2019 22:23
@encukou encukou merged commit 9e3e06e into python:master Jun 2, 2019
@jdemeyer
Copy link
Contributor Author

jdemeyer commented Jun 3, 2019

In Doc/c-api/structures.rst, I planned to give a high-level explanation of the vectorcall protocol (basically a short version of PEP 590). Right now this is not really explained. That's why I defined vectorcallfunc there.

Do you still think that this is a good idea?

@encukou
Copy link
Member

encukou commented Jun 3, 2019

I don't think c-api/structures is a good place, since vectorcall is not a structure.
But perhaps a new chapter on calling under "Abstract Objects Layer" would make sense – calling takes up half of c-api/object already.

DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@jdemeyer @DinoV
bpo-36974: document PEP 590 (pythonGH-13450)
e1e7208
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jdemeyer @encukou @the-knights-who-say-ni @bedevere-bot