-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
gh-142029: Raise ValueError instead of crashing on empty name given to create_builtin()
#142033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kumaraditya303
merged 9 commits into
python:main
from
dr-carlos:importlib-create-builtin
Dec 10, 2025
Merged
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ddcf7e4
Check that `name` is non-empty in `_imp.create_builtin()`
dr-carlos 901b039
Edit NEWS entry
dr-carlos 784c232
Don't use `:func:` in NEWS for undocumented function
dr-carlos 5102f3d
Update function name in NEWS entry
dr-carlos 0350177
Add simple tests for `create_builtin()`
dr-carlos 5d9aa6a
Update formatting in `test_create_builtin()`
dr-carlos 81185df
Raise `ValueError` instead of `TypeError` for empty names
dr-carlos 2165cce
Update NEWS entry
dr-carlos 705b473
Update formatting in `import.c`
dr-carlos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
2 changes: 2 additions & 0 deletions
2
Misc/NEWS.d/next/Core_and_Builtins/2025-11-28-16-45-07.gh-issue-142029.JuXiKu.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Raise :exc:`TypeError` instead of crashing when empty string is used as a | ||
| name in ``importlib._imp.create_builtin``. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.