gh-141510: Update PyDict C API doc for frozendict#145533
gh-141510: Update PyDict C API doc for frozendict#145533vstinner wants to merge 6 commits intopython:mainfrom
Conversation
Mention frozendict support.
|
I used cc @encukou |
encukou
left a comment
There was a problem hiding this comment.
You've missed PyDict_Contains.
I think the info for the current behaviour should be in the main text, not in the versionchanged directive. If nothing else, there's been a suggestion to hide these for older versions.
Oops, fixed.
I updated the PR to mention |
|
@encukou and/or @ZeroIntensity: Do you want to review this change? |
| .. versionchanged:: next | ||
| Also accept :class:`frozendict`. | ||
|
|
There was a problem hiding this comment.
Now, do we need versionchanged at all, since frozendict was added in this version?
| .. versionchanged:: next | |
| Also accept :class:`frozendict`. |
There was a problem hiding this comment.
I think it's nice to have an explicit historical record.
There was a problem hiding this comment.
I prefer to be explicit about the change.
Mention frozendict support.
📚 Documentation preview 📚: https://cpython-previews--145533.org.readthedocs.build/