bpo-38610: Fix possible crashes in several list methods #17022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hold strong references to list elements while calling PyObject_RichCompareBool().
shihai1991
reviewed
Nov 3, 2019
|
Thanks @ZackerySpytz for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
|
Thanks @ZackerySpytz for the quick fix! |
|
GH-17758 is a backport of this pull request to the 3.8 branch. |
|
Sorry, @ZackerySpytz and @pablogsal, I could not cleanly backport this to |
pablogsal
pushed a commit
to pablogsal/cpython
that referenced
this pull request
Dec 30, 2019
…GH-17022) Hold strong references to list elements while calling PyObject_RichCompareBool().. (cherry picked from commit d9e561d) Co-authored-by: Zackery Spytz <[email protected]>
|
GH-17759 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this pull request
Dec 30, 2019
Hold strong references to list elements while calling PyObject_RichCompareBool(). (cherry picked from commit d9e561d) Co-authored-by: Zackery Spytz <[email protected]>
pablogsal
added a commit
that referenced
this pull request
Dec 30, 2019
…) (GH-17759) Hold strong references to list elements while calling PyObject_RichCompareBool().. (cherry picked from commit d9e561d) Co-authored-by: Zackery Spytz <[email protected]> Co-authored-by: Zackery Spytz <[email protected]>
corona10
pushed a commit
to corona10/cpython
that referenced
this pull request
Jan 27, 2020
Hold strong references to list elements while calling PyObject_RichCompareBool().
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
Hold strong references to list elements while calling PyObject_RichCompareBool().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hold strong references to list elements while calling
PyObject_RichCompareBool().
https://bugs.python.org/issue38610