Skip to content

bpo-39019: Implement missing __class_getitem__ for SpooledTemporaryFile #17560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 30, 2019
Merged

bpo-39019: Implement missing __class_getitem__ for SpooledTemporaryFile #17560

merged 5 commits into from
Dec 30, 2019

Conversation

isidentical
Copy link
Member

@isidentical isidentical commented Dec 10, 2019 •
edited by bedevere-bot
Loading

ilevkivskyi
ilevkivskyi reviewed Dec 27, 2019
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Here are couple comments.

ilevkivskyi
ilevkivskyi reviewed Dec 27, 2019
View reviewed changes
ilevkivskyi
ilevkivskyi approved these changes Dec 30, 2019
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ilevkivskyi ilevkivskyi merged commit 09c482f into python:master Dec 30, 2019
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@isidentical @shihai1991
bpo-39019: Implement missing __class_getitem__ for SpooledTemporaryFi…
53176ac 
…le (pythonGH-17560)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZackerySpytz ZackerySpytz ZackerySpytz left review comments

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@isidentical @ilevkivskyi @ZackerySpytz @the-knights-who-say-ni @bedevere-bot