Skip to content

bpo-40077: Remove redundant cast in _json extension module #19438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2020
Merged

bpo-40077: Remove redundant cast in _json extension module #19438

merged 1 commit into from
Apr 9, 2020

Conversation

shihai1991
Copy link
Member

@shihai1991 shihai1991 commented Apr 8, 2020 •
edited by bedevere-bot
Loading

@shihai1991
Copy link
Member Author

@corona10 Hi, Dong-hee Na, congratulations!

this cast is redundant, right?

corona10
corona10 approved these changes Apr 9, 2020
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this :)
Since PyScannerType and PyEncoderType is PyObject*.
Casting is unnecessary things.

lgtm!

@corona10 corona10 requested a review from vstinner April 9, 2020 14:02
@corona10
Copy link
Member

corona10 commented Apr 9, 2020

cc @vstinner

@shihai1991
Copy link
Member Author

Thanks for catching this :)
Since PyScannerType and PyEncoderType is PyObject*.
Casting is unnecessary things.

lgtm!

Thanks, MAYBE you can try use your merge right in this PR ;)

vstinner
vstinner approved these changes Apr 9, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Usually, we don't accept coding style only changes. But I think that it's ok to make an exception here.

@corona10 corona10 merged commit dcb04d9 into python:master Apr 9, 2020
@vstinner
Copy link
Member

vstinner commented Apr 9, 2020

@corona10: Congrats for your first merge ;-)

@corona10
Copy link
Member

corona10 commented Apr 9, 2020

@vstinner Thank you, it is the singularity of life

@corona10 corona10 mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@corona10 corona10 corona10 approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shihai1991 @corona10 @vstinner @the-knights-who-say-ni @bedevere-bot