bpo-40901: Describe what "interface name" means on Windows #20694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @ZackerySpytz @zooba (as you were involved in #13522) I'd appreciate some guidance here. I think news entry can be skipped safely in this case. |
|
Should I ask someone else for a review? Not sure who, I'm thinking people who changed this module's documentation recently. |
taleinat
reviewed
Sep 25, 2020
Doc/library/socket.rst
Outdated
| * friendly name: ``vEthernet (nat)`` | ||
| * description: ``Hyper-V Virtual Ethernet Adapter`` | ||
|
|
||
| This function returns names of the second form from the list. |
There was a problem hiding this comment.
This last sentence is perhaps not as clear as it could be. Perhaps mention the example value ethernet_32770 explicitly?
There was a problem hiding this comment.
That's fair, I'll do that in a minute.
Indeed. |
|
Thanks! Very helpful contribution :) |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 19, 2020
…20694) (cherry picked from commit f85658a) Co-authored-by: Jakub Stasiak <[email protected]>
|
GH-22794 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 19, 2020
…20694) (cherry picked from commit f85658a) Co-authored-by: Jakub Stasiak <[email protected]>
|
GH-22795 is a backport of this pull request to the 3.8 branch. |
miss-islington
added a commit
that referenced
this pull request
Oct 19, 2020
(cherry picked from commit f85658a) Co-authored-by: Jakub Stasiak <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Oct 19, 2020
(cherry picked from commit f85658a) Co-authored-by: Jakub Stasiak <[email protected]>
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue40901