-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
bpo-40939: Remove PEG parser easter egg #20802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Closing and reopening for the CI. |
@pablogsal I don't know if the commit message goes into the squash commit message, but here it's currently wrong, since it mentions renaming and not removing. Should I change it or will you just take the PR title as the commit message of the squash commit? |
I will customize it when I merge :) |
Thanks @lysnikolaou for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
@gvanrossum: Please replace |
Sorry @lysnikolaou and @gvanrossum, I had trouble checking out the |
Honestly I wouldn't back port this. In 3.9 this does serve a purpose. |
A PR is still needed to fix the buildbot errors. |
Okay, can you do it? I don't even know what the buildbot error is. |
Yep, I will take care of it don't worry |
Already got something ready. I'll push soon. |
It no longer serves a purpose (there's only one parser) and having "new" in any name will eventually look odd. Also, it impinges on a potential sub-namespace, `__new_...__`.
There seem to still be some leftovers present:
|
The removal applies to 3.10. |
Oh, I see! I should have read the comments I guess. Sorry for the noise. |
https://bugs.python.org/issue40939