Skip to content

[3.9] bpo-32528: Document the change in inheritance of asyncio.CancelledError (GH-21474) #21606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2020

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 24, 2020

GH-13528 changed asyncio.CancelledError such that it no longer inherits from concurrent.futures.CancelledError. Document the changes in 3.8 .

Automerge-Triggered-By: @1st1
(cherry picked from commit 2a51818)

Co-authored-by: JustAnotherArchivist [email protected]

https://bugs.python.org/issue32528

…or (pythonGH-21474)

GH-msg373510

[bpo-32528]()/pythonGH-13528 changed `asyncio.CancelledError` such that it no longer inherits from `concurrent.futures.CancelledError`. As this affects existing code, specifically when catching the latter instead of the former in exception handling, it should be documented in the "What's new in 3.8?" document.

Automerge-Triggered-By: @1st1
(cherry picked from commit 2a51818)

Co-authored-by: JustAnotherArchivist <[email protected]>
Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@miss-islington
Copy link
Contributor Author

@JustAnotherArchivist: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit ba07d4a into python:3.9 Jul 24, 2020
@miss-islington miss-islington deleted the backport-2a51818-3.9 branch July 24, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants