-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
bpo-41994: Fix refcount issues in Python/import.c #22632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 25ba819 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Co-authored-by: Pablo Galindo <[email protected]>
@ericsnowcurrently, please take a look. It has relation to the code added by you (support of arbitrary mapping as |
This PR is stale because it has been open for 30 days with no activity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through the changes and they look OK to me!
To review, I needed to merge current master & resolve a small conflict; I hope you don't mind me pushing that into this PR.
@ericsnowcurrently, do you want to review as well? I might have missed some big-picture issue.
Thank you @encukou. I planned to merge with master, but it needed some time because there is easy to miss some detail in large image when change how reference counted. Good opportunity to do one more review. |
🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 03e405f 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Unfortunately that last merge was with a leaking master, which is now fixed. Another merge should fix the tests. |
🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit c31124f 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
And now the tests failed because of bpo-42794. This PR seems cursed :( |
Thanks @serhiy-storchaka for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
Sorry, @serhiy-storchaka and @encukou, I could not cleanly backport this to |
https://bugs.python.org/issue41994