Skip to content

bpo-43155: Add PyCMethod_New to PC/python3dll.c #24500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 1 commit into from
Feb 16, 2021
Merged

bpo-43155: Add PyCMethod_New to PC/python3dll.c #24500

vstinner merged 1 commit into from
Feb 16, 2021

Conversation

@ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Feb 10, 2021 •
edited by bedevere-bot
Loading

@ZackerySpytz ZackerySpytz requested a review from a team as a code owner February 10, 2021 11:19
encukou
encukou approved these changes Feb 12, 2021
View reviewed changes
Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have Windows to test with, but I agree that PyCMethod_New should be part of the limited ABI.

@vstinner vstinner merged commit 8a8b5df into python:master Feb 16, 2021
@miss-islington
Copy link
Contributor

miss-islington commented Feb 16, 2021

Thanks @ZackerySpytz for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Feb 16, 2021

Sorry, @ZackerySpytz and @vstinner, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 8a8b5df93f379f561aab4f2fc5b2ad54f5009f7a 3.9

@vstinner
Copy link
Member

vstinner commented Feb 16, 2021

I don't have Windows to test with, but I agree that PyCMethod_New should be part of the limited ABI.

I concur with @encukou. I merged the fix, thanks.

@vstinner
Copy link
Member

vstinner commented Feb 16, 2021

@ZackerySpytz: can you please try to backport it manually to 3.9?

@ZackerySpytz
Copy link
Contributor Author

ZackerySpytz commented Feb 16, 2021

Okay, I will create a backport for 3.9.

ZackerySpytz added a commit to ZackerySpytz/cpython that referenced this pull request Feb 16, 2021
@ZackerySpytz
bpo-43155: Add PyCMethod_New to PC/python3.def (pythonGH-24500)
db7ca86 
(cherry picked from commit 8a8b5df)
@bedevere-bot
Copy link

bedevere-bot commented Feb 16, 2021

GH-24554 is a backport of this pull request to the 3.9 branch.

vstinner pushed a commit that referenced this pull request Feb 17, 2021
@ZackerySpytz
bpo-43155: Add PyCMethod_New to PC/python3.def (GH-24500) (GH-24554)
ebe20d9 
(cherry picked from commit 8a8b5df)
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@ZackerySpytz @adorilson
bpo-43155: Add PyCMethod_New to PC/python3dll.c (pythonGH-24500)
6f9c56e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou approved these changes

Assignees

@vstinner vstinner

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ZackerySpytz @miss-islington @vstinner @bedevere-bot @encukou @the-knights-who-say-ni