-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
bpo-43220: Accept explicit default args in required groups #24526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-43220: Accept explicit default args in required groups #24526
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
Previously if you had a default argument on a required mutually exclusive group and the default was explicitly passed, it was treated as if no value was passed. Now it accepts that value.
0b271c9
to
8526023
Compare
Please add a NEWS entry using Blurb. |
Updated! |
This PR is stale because it has been open for 30 days with no activity. |
Any idea who I can get to review? |
@rhettinger friendly bump! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I merged main into this to resolve the conflict. @furkanonder should I do anything else here or is the process to wait for further review? |
Thank you for your contribution. It was fixed in other way by #124307. |
Previously if you had a default argument on a required mutually
exclusive group and the default was explicitly passed, it was treated
as if no value was passed. Now it accepts that value.
https://bugs.python.org/issue43220