Skip to content

bpo-43220: Accept explicit default args in required groups #24526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

keith
Copy link

@keith keith commented Feb 14, 2021

Previously if you had a default argument on a required mutually
exclusive group and the default was explicitly passed, it was treated
as if no value was passed. Now it accepts that value.

https://bugs.python.org/issue43220

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@keith

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Previously if you had a default argument on a required mutually
exclusive group and the default was explicitly passed, it was treated
as if no value was passed. Now it accepts that value.
@keith keith force-pushed the ks/bpo-43220-accept-explicit-default-args-in-required-groups branch from 0b271c9 to 8526023 Compare February 14, 2021 06:41
@rhettinger
Copy link
Contributor

Please add a NEWS entry using Blurb.

@keith
Copy link
Author

keith commented Feb 16, 2021

Updated!

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Mar 19, 2021
@keith
Copy link
Author

keith commented Mar 19, 2021

Any idea who I can get to review?

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Mar 20, 2021
@rhettinger rhettinger self-requested a review April 7, 2021 08:59
@keith
Copy link
Author

keith commented May 9, 2022

@rhettinger friendly bump!

Copy link
Contributor

@furkanonder furkanonder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@keith
Copy link
Author

keith commented Jul 18, 2023

I merged main into this to resolve the conflict. @furkanonder should I do anything else here or is the process to wait for further review?

@serhiy-storchaka
Copy link
Member

Thank you for your contribution. It was fixed in other way by #124307.

@keith keith deleted the ks/bpo-43220-accept-explicit-default-args-in-required-groups branch September 25, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants