Skip to content

bpo-35134: Move Include/{pyarena.h,pyctype.h} to Include/cpython #24550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 17, 2021

Conversation

nw0
Copy link
Contributor

@nw0 nw0 commented Feb 16, 2021

Move non-limited C API headers pyarena.h, pyctype.h into
Include/cpython.

In the same vein as previous PRs by @vstinner.

https://bugs.python.org/issue35134

Move non-limited C API headers pyarena.h, pyctype.h into
Include/cpython.
@vstinner
Copy link
Member

Can you please add a NEWS entry in the C API to mention that pytime.h, pyarena.h and pyctype.h headers were moved into the cpython/ directory and must not be included directly: they are already included by Python.h.

You can add a :ref:`Include Files <api-includes>` link to https://docs.python.org/dev/c-api/intro.html#include-files.

@nw0
Copy link
Contributor Author

nw0 commented Feb 17, 2021

Can you please add a NEWS entry in the C API to mention that pytime.h, pyarena.h and pyctype.h headers were moved into the cpython/ directory and must not be included directly: they are already included by Python.h.

You can add a :ref:`Include Files <api-includes>` link to https://docs.python.org/dev/c-api/intro.html#include-files.

Updated. Thanks for your review!

@vstinner vstinner merged commit 366dc3a into python:master Feb 17, 2021
@vstinner
Copy link
Member

Merged, thanks!

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
…thonGH-24550)

Move non-limited C API headers pyarena.h and pyctype.h
into Include/cpython/ directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants