Skip to content

[3.9] Revert "[3.9] bpo-43725: Add ignore file for the abidump check" #25394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2021
Merged

[3.9] Revert "[3.9] bpo-43725: Add ignore file for the abidump check" #25394

merged 1 commit into from
Apr 13, 2021

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Apr 13, 2021 •
edited by bedevere-bot
Loading

@pablogsal pablogsal changed the title Revert "[3.9] bpo-43725: Add ignore file for the abidump check" [3.9] Revert "[3.9] bpo-43725: Add ignore file for the abidump check" Apr 13, 2021
@vstinner
Copy link
Member

_Py_M__importlib_bootstrap_external should be ignored explictly, no? See: https://bugs.python.org/issue43725#msg390660

@pablogsal
Copy link
Member Author

_Py_M__importlib_bootstrap_external should be ignored explictly, no? See: https://bugs.python.org/issue43725#msg390660

That is only for 3.8

vstinner
vstinner approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If we need to manually ignore symbols tomorrow, we can add again the ignorefile.

@pablogsal pablogsal merged commit 4da5ca5 into 3.9 Apr 13, 2021
@pablogsal pablogsal deleted the revert-25323-abicheck-ignore3.9 branch April 13, 2021 23:26
@gpshead gpshead mentioned this pull request May 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pablogsal @vstinner @the-knights-who-say-ni @bedevere-bot