Skip to content

bpo-43933: Set frame.f_lineno during call to __exit__ #25719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 30, 2021
Merged

bpo-43933: Set frame.f_lineno during call to __exit__ #25719

merged 3 commits into from
Apr 30, 2021

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Apr 29, 2021 •
edited by bedevere-bot
Loading

Sets the line number for the call to __exit__ when leaving a with statement to the line number of the with statement.

https://bugs.python.org/issue43933

@markshannon markshannon force-pushed the line-number-for-with-exit branch from ba32a52 to d22409e Compare April 29, 2021 13:04
@encukou
Copy link
Member

encukou commented Apr 29, 2021

The "Check if generated files are up to date" test is failing because of unfortunate timing when merging other PRs (GH-25315, GH-25687).
It's OK to ignore it. Sorry for the inconvenience.

@markshannon markshannon reopened this Apr 29, 2021
@markshannon
Copy link
Member Author

3.10b1 is imminent, and no one has objected.
So, I'm merging this.

@markshannon markshannon merged commit 5979e81 into python:master Apr 30, 2021
@markshannon markshannon deleted the line-number-for-with-exit branch May 4, 2021 09:00
postgres-mirror pushed a commit to postgres/postgres that referenced this pull request Jun 5, 2021
@petere
Fix subtransaction test for Python 3.10
4a682d8 
Starting with Python 3.10, the stacktrace looks differently:
  -  PL/Python function "subtransaction_exit_subtransaction_in_with", line 3, in <module>
  -    s.__exit__(None, None, None)
  +  PL/Python function "subtransaction_exit_subtransaction_in_with", line 2, in <module>
  +    with plpy.subtransaction() as s:
Using try/except specifically makes the error look always the same.

(See python/cpython#25719 for the discussion
of this change in Python.)

Author: Honza Horak <[email protected]>
Discussion: https://www.postgresql.org/message-id/flat/853083.1620749597%40sss.pgh.pa.us
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1959080
postgres-mirror pushed a commit to postgres/postgres that referenced this pull request Jun 17, 2021
@petere
Fix subtransaction test for Python 3.10
9c31e41 
Starting with Python 3.10, the stacktrace looks differently:
  -  PL/Python function "subtransaction_exit_subtransaction_in_with", line 3, in <module>
  -    s.__exit__(None, None, None)
  +  PL/Python function "subtransaction_exit_subtransaction_in_with", line 2, in <module>
  +    with plpy.subtransaction() as s:
Using try/except specifically makes the error look always the same.

(See python/cpython#25719 for the discussion
of this change in Python.)

Author: Honza Horak <[email protected]>
Discussion: https://www.postgresql.org/message-id/flat/853083.1620749597%40sss.pgh.pa.us
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1959080
postgres-mirror pushed a commit to postgres/postgres that referenced this pull request Jun 17, 2021
@petere
Fix subtransaction test for Python 3.10
9438962 
Starting with Python 3.10, the stacktrace looks differently:
  -  PL/Python function "subtransaction_exit_subtransaction_in_with", line 3, in <module>
  -    s.__exit__(None, None, None)
  +  PL/Python function "subtransaction_exit_subtransaction_in_with", line 2, in <module>
  +    with plpy.subtransaction() as s:
Using try/except specifically makes the error look always the same.

(See python/cpython#25719 for the discussion
of this change in Python.)

Author: Honza Horak <[email protected]>
Discussion: https://www.postgresql.org/message-id/flat/853083.1620749597%40sss.pgh.pa.us
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1959080
postgres-mirror pushed a commit to postgres/postgres that referenced this pull request Jun 17, 2021
@petere
Fix subtransaction test for Python 3.10
6b6fbfd 
Starting with Python 3.10, the stacktrace looks differently:
  -  PL/Python function "subtransaction_exit_subtransaction_in_with", line 3, in <module>
  -    s.__exit__(None, None, None)
  +  PL/Python function "subtransaction_exit_subtransaction_in_with", line 2, in <module>
  +    with plpy.subtransaction() as s:
Using try/except specifically makes the error look always the same.

(See python/cpython#25719 for the discussion
of this change in Python.)

Author: Honza Horak <[email protected]>
Discussion: https://www.postgresql.org/message-id/flat/853083.1620749597%40sss.pgh.pa.us
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1959080
postgres-mirror pushed a commit to postgres/postgres that referenced this pull request Jun 17, 2021
@petere
Fix subtransaction test for Python 3.10
3989f8f 
Starting with Python 3.10, the stacktrace looks differently:
  -  PL/Python function "subtransaction_exit_subtransaction_in_with", line 3, in <module>
  -    s.__exit__(None, None, None)
  +  PL/Python function "subtransaction_exit_subtransaction_in_with", line 2, in <module>
  +    with plpy.subtransaction() as s:
Using try/except specifically makes the error look always the same.

(See python/cpython#25719 for the discussion
of this change in Python.)

Author: Honza Horak <[email protected]>
Discussion: https://www.postgresql.org/message-id/flat/853083.1620749597%40sss.pgh.pa.us
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1959080
postgres-mirror pushed a commit to postgres/postgres that referenced this pull request Jun 17, 2021
@petere
Fix subtransaction test for Python 3.10
1a2752b 
Starting with Python 3.10, the stacktrace looks differently:
  -  PL/Python function "subtransaction_exit_subtransaction_in_with", line 3, in <module>
  -    s.__exit__(None, None, None)
  +  PL/Python function "subtransaction_exit_subtransaction_in_with", line 2, in <module>
  +    with plpy.subtransaction() as s:
Using try/except specifically makes the error look always the same.

(See python/cpython#25719 for the discussion
of this change in Python.)

Author: Honza Horak <[email protected]>
Discussion: https://www.postgresql.org/message-id/flat/853083.1620749597%40sss.pgh.pa.us
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1959080
mrdrivingduck pushed a commit to mrdrivingduck/PolarDB-for-PostgreSQL that referenced this pull request Mar 9, 2024
@petere @mrdrivingduck
Fix subtransaction test for Python 3.10
7e7f2e9 
Starting with Python 3.10, the stacktrace looks differently:
  -  PL/Python function "subtransaction_exit_subtransaction_in_with", line 3, in <module>
  -    s.__exit__(None, None, None)
  +  PL/Python function "subtransaction_exit_subtransaction_in_with", line 2, in <module>
  +    with plpy.subtransaction() as s:
Using try/except specifically makes the error look always the same.

(See python/cpython#25719 for the discussion
of this change in Python.)

Author: Honza Horak <[email protected]>
Discussion: https://www.postgresql.org/message-id/flat/853083.1620749597%40sss.pgh.pa.us
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1959080
mrdrivingduck pushed a commit to ApsaraDB/PolarDB-for-PostgreSQL that referenced this pull request Mar 10, 2024
@petere @mrdrivingduck
Fix subtransaction test for Python 3.10
a5cd81b 
Starting with Python 3.10, the stacktrace looks differently:
  -  PL/Python function "subtransaction_exit_subtransaction_in_with", line 3, in <module>
  -    s.__exit__(None, None, None)
  +  PL/Python function "subtransaction_exit_subtransaction_in_with", line 2, in <module>
  +    with plpy.subtransaction() as s:
Using try/except specifically makes the error look always the same.

(See python/cpython#25719 for the discussion
of this change in Python.)

Author: Honza Horak <[email protected]>
Discussion: https://www.postgresql.org/message-id/flat/853083.1620749597%40sss.pgh.pa.us
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1959080
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@markshannon @encukou @the-knights-who-say-ni @bedevere-bot