bpo-43908: check_set_special_type_attr() and type_set_annotations() now check for immutable flag #25743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… iso. !Py_TPFLAGS_HEAPTYPE
|
cc. @vstinner |
erlend-aasland
changed the title
vstinner
reviewed
Apr 30, 2021
Co-authored-by: Victor Stinner <[email protected]>
vstinner
reviewed
Apr 30, 2021
vstinner
reviewed
Apr 30, 2021
|
test_descr does crash on the Windows CI. |
|
I look the liberty of fixing |
Thanks, Victor! I'm offline for an hour now. Feel free to take care of the fixes and land the PR :) Or I'll look at it later this afternoon. |
No problem, I pushed a fix for test_descr in your PR. |
|
Thanks! |
|
Merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue43908