Skip to content

[3.10] bpo-44116: Add GC support to _csv heap types (GH-26074) #26081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2021
Merged

[3.10] bpo-44116: Add GC support to _csv heap types (GH-26074) #26081

merged 1 commit into from
May 12, 2021

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 12, 2021 •
edited by bedevere-bot
Loading

(cherry picked from commit e5ba1fe)

Co-authored-by: Erlend Egeberg Aasland [email protected]

https://bugs.python.org/issue44116

@miss-islington
bpo-44116: Add GC support to _csv heap types (pythonGH-26074)
911bfef 
(cherry picked from commit e5ba1fe)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@bedevere-bot bedevere-bot mentioned this pull request May 12, 2021
Merged
@miss-islington
Copy link
Contributor Author

@erlend-aasland and @pablogsal: Status check is done, and it's a success ✅ .

2 similar comments
@miss-islington
Copy link
Contributor Author

@erlend-aasland and @pablogsal: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@erlend-aasland and @pablogsal: Status check is done, and it's a success ✅ .

@erlend-aasland
Copy link
Contributor

Can I add the automerge label, @pablogsal?

@pablogsal
Copy link
Member

Backports are automatically merged when all CI passed if a core dev approves :)

@erlend-aasland
Copy link
Contributor

Backports are automatically merged when all CI passed if a core dev approves :)

Convenient! :)

@erlend-aasland
Copy link
Contributor

Looks like Miss Islington needs a bugfix ;) #automerge

@pablogsal pablogsal merged commit ba260ac into python:3.10 May 12, 2021
@miss-islington miss-islington deleted the backport-e5ba1fe-3.10 branch May 12, 2021 18:56
@pablogsal
Copy link
Member

CC: @Mariatta

Seems that Miss islington didn't merge this PR even if all test passed :(

@erlend-aasland
Copy link
Contributor

Perhaps it is intentional: python/miss-islington#253

(I just skimmed the "status changed" code, so I might be wrong.)

@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miss-islington @erlend-aasland @pablogsal @the-knights-who-say-ni @bedevere-bot