bpo-44249 Update README.rst #26385
bpo-44249 Update README.rst #26385
Conversation
I signed CLA , look over it again |
Ayushparikh-code
changed the title
Ayushparikh-code
changed the title
README.rst
Outdated
| workload. This is necessary in order to profile the interpreter execution. | ||
| Note also that any output, both stdout and stderr, that may appear at this step | ||
| workload. This is necessary to profile the interpreter's execution. | ||
| Note also that any output, both stdout, and stderr, that may appear at this step |
There was a problem hiding this comment.
This should not change; it's not a list, it's just a sub-section of the sentence. I'm not sure this note is true anymore, though.
There was a problem hiding this comment.
I am reverting except for 's.
README.rst
Outdated
| is suppressed. | ||
|
|
||
| The final step is to build the actual interpreter, using the information | ||
| collected from the instrumented one. The end result will be a Python binary | ||
| collected from the instrumented one. The result will be a Python binary |
There was a problem hiding this comment.
I don't think this needs to change.
| @@ -0,0 +1 @@ | |||
| updated and corrected readme with some grammatical mistakes | |||
There was a problem hiding this comment.
This entry is definitely not needed, but NEWS entries should also have proper grammar :)
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
There was a problem hiding this comment.
@zware, please do the honors of closing the PR unless @Ayushparikh-code has any rebuttals for the changes proposed.
Edit: I think I misread some of the reviews I guess to mean the change wasn't necessary, my bad.
Co-authored-by: Zachary Ware <[email protected]>
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @zware: please review the changes made to this pull request. |
| flags for each flavor. Note that this is just an intermediary step. The | ||
| binary resulting from this step is not good for real-life workloads as it has |
There was a problem hiding this comment.
These two changes and one other are correct. Will merge when CI done.
README.rst
Outdated
| workload. This is necessary in order to profile the interpreter execution. | ||
| Note also that any output, both stdout and stderr, that may appear at this step | ||
| workload. This is necessary to profile the interpreter's execution. | ||
| Note also that any output, both stdout, and stderr, that may appear at this step |
There was a problem hiding this comment.
I am reverting except for 's.
terryjreedy
added
needs backport to 3.9
|
@nanjekyejoannah Trivial changes like this, with no creative content, do not need a CLA, But I still think getting it is better. If nothing else, so the matter is taken care of for next suggestion. |
|
Thanks @Ayushparikh-code for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9. |
|
GH-26434 is a backport of this pull request to the 3.10 branch. |
(cherry picked from commit acac6c7) Co-authored-by: Ayush Parikh <[email protected]>
(cherry picked from commit acac6c7) Co-authored-by: Ayush Parikh <[email protected]>
|
GH-26435 is a backport of this pull request to the 3.9 branch. |
(cherry picked from commit acac6c7) Co-authored-by: Ayush Parikh <[email protected]>
(cherry picked from commit acac6c7) Co-authored-by: Ayush Parikh <[email protected]>
https://bugs.python.org/issue44249