Skip to content

[3.10] bpo-42972: Fully implement GC protocol for re types (GH-26368) #26411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 27, 2021

(cherry picked from commit fba42d1)

Co-authored-by: Erlend Egeberg Aasland [email protected]

https://bugs.python.org/issue42972

(cherry picked from commit fba42d1)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@miss-islington
Copy link
Contributor Author

@erlend-aasland and @vstinner: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@erlend-aasland and @vstinner: Status check is done, and it's a success ✅ .

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Contributor Author

@erlend-aasland and @vstinner: Status check is done, and it's a failure ❌ .

@vstinner
Copy link
Member

Tests / Windows (x64) (pull_request) Failing

It failed because of: https://bugs.python.org/issue44252#msg394581

I re-run the job.

@vstinner vstinner closed this May 27, 2021
@miss-islington miss-islington deleted the backport-fba42d1-3.10 branch May 27, 2021 21:57
@vstinner
Copy link
Member

Problem 2: I had to cancel the Ubuntu job after 1 hour since downloading the ccache never completed.

Problem 3: I cannot re-run all jobs, the GitHub UI only offers me [cancel workflow] choice. I closed the PR, I will recreate it instead. Let's hope that https://bugs.python.org/issue44252#msg394581 doesn't occur again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants