Skip to content

[3.10] bpo-42972: Fully implement GC protocol for re types (GH-26368) #26414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2021

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 27, 2021

(cherry picked from commit fba42d1)

Co-authored-by: Erlend Egeberg Aasland [email protected]

https://bugs.python.org/issue42972

(cherry picked from commit fba42d1)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@miss-islington
Copy link
Contributor Author

@erlend-aasland and @vstinner: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@erlend-aasland and @vstinner: Status check is done, and it's a success ✅ .

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@vstinner
Copy link
Member

On a single CI run, https://bugs.python.org/issue44252 occurred 3 times on 4 Windows jobs.

Tests / Windows (x86) (pull_request) Failing after 13m — Windows (x86)

=> 1 test failed: test_asyncio

Tests / Windows (x64) (pull_request) Failing after 13m — Windows (x64)

0:00:32 load avg: 6.46 [ 52/427/1] test_httplib crashed (Exit code 3221225477)
(...)
test_host_port (test.test_httplib.HTTPSTest) ... ok
Windows fatal exception: access violation

Azure Pipelines PR — #20210527.52 failed

64-bit:

test_host_port (test.test_httplib.HTTPSTest) ... ok
Windows fatal exception: access violation

32 bit:

test_host_port (test.test_httplib.HTTPSTest) ... ok
Windows fatal exception: access violation

@vstinner
Copy link
Member

I re-run GHA jobs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants