Skip to content

bpo-38323: Remove test_cancel_make_subprocess_transport_exec as it has a rance condicion #26541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Jun 4, 2021

@pablogsal pablogsal requested review from vstinner and asvetlov June 4, 2021 22:32
@pablogsal pablogsal requested a review from 1st1 as a code owner June 4, 2021 22:32
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Jun 4, 2021
@pablogsal pablogsal added skip news needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes and removed tests Tests in the Lib/test dir labels Jun 4, 2021
@pablogsal pablogsal changed the title bpo-38323: Remove test_cancel_make_subprocess_transport_exec as it ha… bpo-38323: Remove test_cancel_make_subprocess_transport_exec as it has a rance condicion Jun 4, 2021
@pablogsal
Copy link
Member Author

Turns out this is not enough:

./python -u -m test test_asyncio -m SubprocessMultiLoopWatcherTests -F --timeout=10.0 -j20
...
  File "/home/pablogsal/github/cpython/Lib/unittest/case.py", line 592 in run
  File "/home/pablogsal/github/cpython/Lib/unittest/case.py", line 652 in __call__
  File "/home/pablogsal/github/cpython/Lib/unittest/suite.py", line 122 in run
  File "/home/pablogsal/github/cpython/Lib/unittest/suite.py", line 84 in __call__
  File "/home/pablogsal/github/cpython/Lib/unittest/suite.py", line 122 in run
  File "/home/pablogsal/github/cpython/Lib/unittest/suite.py", line 84 in __call__
  File "/home/pablogsal/github/cpython/Lib/unittest/suite.py", line 122 in run
  File "/home/pablogsal/github/cpython/Lib/unittest/suite.py", line 84 in __call__
  File "/home/pablogsal/github/cpython/Lib/unittest/suite.py", line 122 in run
  File "/home/pablogsal/github/cpython/Lib/unittest/suite.py", line 84 in __call__
  File "/home/pablogsal/github/cpython/Lib/unittest/suite.py", line 122 in run
  File "/home/pablogsal/github/cpython/Lib/unittest/suite.py", line 84 in __call__
  File "/home/pablogsal/github/cpython/Lib/test/support/testresult.py", line 169 in run
  File "/home/pablogsal/github/cpython/Lib/test/support/__init__.py", line 960 in _run_suite
  File "/home/pablogsal/github/cpython/Lib/test/support/__init__.py", line 1083 in run_unittest
  File "/home/pablogsal/github/cpython/Lib/test/libregrtest/runtest.py", line 210 in _test_module
  File "/home/pablogsal/github/cpython/Lib/test/libregrtest/runtest.py", line 246 in _runtest_inner2
  File "/home/pablogsal/github/cpython/Lib/test/libregrtest/runtest.py", line 282 in _runtest_inner
  File "/home/pablogsal/github/cpython/Lib/test/libregrtest/runtest.py", line 154 in _runtest
  File "/home/pablogsal/github/cpython/Lib/test/libregrtest/runtest.py", line 194 in runtest
  File "/home/pablogsal/github/cpython/Lib/test/libregrtest/runtest_mp.py", line 81 in run_tests_worker
  File "/home/pablogsal/github/cpython/Lib/test/libregrtest/main.py", line 661 in _main
  File "/home/pablogsal/github/cpython/Lib/test/libregrtest/main.py", line 641 in main
  File "/home/pablogsal/github/cpython/Lib/test/libregrtest/main.py", line 719 in main
  File "/home/pablogsal/github/cpython/Lib/test/regrtest.py", line 43 in _main
  File "/home/pablogsal/github/cpython/Lib/test/regrtest.py", line 47 in <module>
  File "/home/pablogsal/github/cpython/Lib/runpy.py", line 86 in _run_code
  File "/home/pablogsal/github/cpython/Lib/runpy.py", line 196 in _run_module_as_main
Kill <TestWorkerProcess #1 running test=test_asyncio pid=30022 time=950 ms> process group
Kill <TestWorkerProcess #2 running test=test_asyncio pid=30093 time=679 ms> process group
Kill <TestWorkerProcess #3 running test=test_asyncio pid=29847 time=1.6 sec> process group
Kill <TestWorkerProcess #4 running test=test_asyncio pid=29757 time=1.9 sec> process group
Kill <TestWorkerProcess #5 running test=test_asyncio pid=29922 time=1.3 sec> process group
Kill <TestWorkerProcess #6 running test=test_asyncio pid=29859 time=1.5 sec> process group
Kill <TestWorkerProcess #7 running test=test_asyncio pid=30146 time=362 ms> process group
Kill <TestWorkerProcess #8 running test=test_asyncio pid=29880 time=1.4 sec> process group
Kill <TestWorkerProcess #9 running test=test_asyncio pid=30028 time=934 ms> process group
Kill <TestWorkerProcess #10 running test=test_asyncio pid=29968 time=1.2 sec> process group
Kill <TestWorkerProcess #11 running test=test_asyncio pid=30000 time=1.0 sec> process group
Kill <TestWorkerProcess #12 running test=test_asyncio pid=29765 time=1.9 sec> process group
Kill <TestWorkerProcess #13 running test=test_asyncio pid=30183 time=112 ms> process group
Kill <TestWorkerProcess #14 running test=test_asyncio pid=30161 time=234 ms> process group
Kill <TestWorkerProcess #15 running test=test_asyncio pid=29888 time=1.4 sec> process group
Kill <TestWorkerProcess #16 running test=test_asyncio pid=29743 time=2.0 sec> process group
Kill <TestWorkerProcess #18 running test=test_asyncio pid=30101 time=548 ms> process group
Kill <TestWorkerProcess #19 running test=test_asyncio pid=29885 time=1.4 sec> process group
Kill <TestWorkerProcess #20 running test=test_asyncio pid=29762 time=1.9 sec> process group

== Tests result: FAILURE ==

565 tests OK.

1 test failed:
    test_asyncio

Total duration: 1 min 1 sec

@cjerdonek
Copy link
Member

Also, @pablogsal, you don't want to remove the methods because that removes the test for every subclass. You just want to skip the concrete SubprocessMultiLoopWatcherTests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants