bpo-43475: Fix the Python implementation of hash of Decimal NaN #26679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.assertEqual(hashit(value), hashit(int(value))) | ||
|
|
||
| #the same hash that to an int | ||
| self.assertEqual(hashit(Decimal(23)), hashit(23)) |
There was a problem hiding this comment.
Covered by tests above.
Comment on lines
-1822
to
-1823
| self.assertTrue(hashit(Decimal('Inf'))) | ||
| self.assertTrue(hashit(Decimal('-Inf'))) |
There was a problem hiding this comment.
Covered by tests below.
|
|
||
| #the same hash that to an int | ||
| self.assertEqual(hashit(Decimal(23)), hashit(23)) | ||
| self.assertRaises(TypeError, hash, Decimal('sNaN')) |
There was a problem hiding this comment.
Moved to test_hash_method_nan.
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
GH-26706 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 13, 2021
…onGH-26679) (cherry picked from commit 9f1c5f6) Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Jun 13, 2021
…6679) (cherry picked from commit 9f1c5f6) Co-authored-by: Serhiy Storchaka <[email protected]>
jdevries3133
pushed a commit
to jdevries3133/cpython
that referenced
this pull request
Jun 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue43475