bpo-44353: Expand NewType tests for complex __qualname__. #27311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make NewType pickleable by name.
pablogsal
approved these changes
Jul 23, 2021
|
Pls, check for refleaks before landing because these tests can easily fail with -R if the caches are not cleaned up |
|
Checked, there are no refleaks. But there are deprecation warnings (unrelated). |
|
@ambv: Please replace |
|
Thanks @serhiy-storchaka for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
Sorry, @serhiy-storchaka and @ambv, I could not cleanly backport this to |
ambv
pushed a commit
to ambv/cpython
that referenced
this pull request
Jul 24, 2021
…honGH-27311) Make NewType pickleable by name.. (cherry picked from commit e89ef0a) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-27326 is a backport of this pull request to the 3.10 branch. |
ambv
added a commit
that referenced
this pull request
Jul 24, 2021
…7311) (GH-27326) Make NewType pickleable by name. (cherry picked from commit e89ef0a) Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make NewType pickleable by name.
https://bugs.python.org/issue44353