Skip to content

bpo-45229: Make tkinter tests discoverable #28637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2021
Merged

bpo-45229: Make tkinter tests discoverable #28637

merged 1 commit into from
Oct 13, 2021

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Sep 29, 2021 •
edited by bedevere-bot
Loading

@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Sep 29, 2021
@serhiy-storchaka serhiy-storchaka requested a review from a team as a code owner September 29, 2021 20:24
@ambv ambv added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 6, 2021
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ambv for commit 53d74c9 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 6, 2021
@ambv ambv merged commit f59ed3c into python:main Oct 13, 2021
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka and @ambv, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker f59ed3c310a7ceebf2a56a84ea969a7f75d95b64 3.9

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 13, 2021
@bedevere-bot
Copy link

GH-28927 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 13, 2021
@serhiy-storchaka @miss-islington
bpo-45229: Make tkinter tests discoverable (pythonGH-28637)
195de49 
(cherry picked from commit f59ed3c)

Co-authored-by: Serhiy Storchaka <[email protected]>
ambv pushed a commit to ambv/cpython that referenced this pull request Oct 13, 2021
@serhiy-storchaka @ambv
[3.9] bpo-45229: Make tkinter tests discoverable (pythonGH-28637).
1435b3f 
(cherry picked from commit f59ed3c)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot
Copy link

GH-28929 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Oct 13, 2021
ambv pushed a commit that referenced this pull request Oct 13, 2021
@miss-islington @serhiy-storchaka
bpo-45229: Make tkinter tests discoverable (GH-28637) (GH-28927)
151234f 
(cherry picked from commit f59ed3c)

Co-authored-by: Serhiy Storchaka <[email protected]>
ambv added a commit that referenced this pull request Oct 13, 2021
@ambv @serhiy-storchaka
[3.9] bpo-45229: Make tkinter tests discoverable (GH-28637) (GH-28929)
5d74713 
(cherry picked from commit f59ed3c)

Co-authored-by: Serhiy Storchaka <[email protected]>
@serhiy-storchaka serhiy-storchaka mentioned this pull request May 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ambv ambv

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@serhiy-storchaka @bedevere-bot @miss-islington @ambv @the-knights-who-say-ni