-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
bpo-45359: Support TopologicalSorter type subscript #28714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-45359: Support TopologicalSorter type subscript #28714
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day We also demand... A SHRUBBERY! You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
FYI: CLA has been signed, pending acceptance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. The only missing thing is a test at https://github.com/python/cpython/blob/main/Lib/test/test_genericalias.py
I think this is ready for another look when folks have time. Thanks! |
Add
TopologicalSorter.__class_getitem__ = classmethod(GenericAlias)
to support runtime subscription.https://bugs.python.org/issue45359
Automerge-Triggered-By: GH:isidentical