Skip to content

bpo-16379: Fix SQLite version checks in test_module_constants() #28809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2021
Merged

bpo-16379: Fix SQLite version checks in test_module_constants() #28809

merged 1 commit into from
Oct 7, 2021

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Oct 7, 2021 •
edited by miss-islington
Loading

https://bugs.python.org/issue16379

Automerge-Triggered-By: GH:pablogsal

@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Oct 7, 2021
@erlend-aasland
Copy link
Contributor Author

@pablogsal Can I reuse issue 16379 for this, or is the skip issue label ok here?

@erlend-aasland
Copy link
Contributor Author

GH-27786 (which introduced these tests) was run multiple times with the buildbots. There is apparently too little variation of SQLite versions in the buildbots.

@pablogsal
Copy link
Member

@pablogsal Can I reuse issue 16379 for this, or is the skip issue label ok here?

You can reuse the issue if you wish :)

@pablogsal pablogsal changed the title Fix SQLite version checks in test_module_constants() bpo-16379: Fix SQLite version checks in test_module_constants() Oct 7, 2021
@erlend-aasland
Copy link
Contributor Author

Thanks, Pablo :)

@miss-islington
Copy link
Contributor

@erlend-aasland: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 8deb7af into python:main Oct 7, 2021
@erlend-aasland erlend-aasland deleted the sqlite-fix-version-checks branch October 7, 2021 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erlend-aasland @pablogsal @miss-islington @the-knights-who-say-ni @bedevere-bot