bpo-44525: Add recursive checks for CALL_FUNCTION_BUILTIN_O
#29271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping news as it shares the same one in PR #26934. |
markshannon
reviewed
Oct 28, 2021
| @@ -4742,8 +4742,14 @@ _PyEval_EvalFrameDefault(PyThreadState *tstate, InterpreterFrame *frame, int thr | |||
| STAT_INC(CALL_FUNCTION, hit); | |||
|
|
|||
| PyCFunction cfunc = PyCFunction_GET_FUNCTION(callable); | |||
| // This is slower but CPython promises to check all non-vectorcall | |||
There was a problem hiding this comment.
OOI any idea how much slower?
Not that it matters, as we need to be correct.
There was a problem hiding this comment.
I'll try to get some numbers by this weekend.
There was a problem hiding this comment.
No need to bother. We need to make this change regardless.
I was just curious, but not so curious that I can be bothered running the benchmarks myself 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue44525