-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
bpo-45747: Detect gdbm/dbm dependencies in configure (GH-29467) #29467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 New build scheduled with the buildbot fleet by @tiran for commit 73438e406438b95b299ddc37d4e8867053fbadfc 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
🤖 New build scheduled with the buildbot fleet by @tiran for commit dad6caa04c8a9ed153341a7ad644cb831f0d02ef 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Signed-off-by: Christian Heimes <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments about configure.ac
(I haven't looked at the setup.py
changes yet)
AC_CHECK_LIB([ndbm], [dbm_open]) | ||
LIBS="$LIBS_SAVE" | ||
AC_CHECK_LIB([gdbm_compat], [dbm_open]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we can fold these into:
AC_CHECK_LIB([ndbm], [dbm_open]) | |
LIBS="$LIBS_SAVE" | |
AC_CHECK_LIB([gdbm_compat], [dbm_open]) | |
AC_SEARCH_LIBS([dbm_open], [ndbm gdbm_compat]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AC_SEARCH_LIBS()
does not create HAVE_LIBFOO
entries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that's unfortunate.
Co-authored-by: Erlend Egeberg Aasland <[email protected]>
Co-authored-by: Erlend Egeberg Aasland <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Is it worth it to document the USE_*
defines in whatsnew
?
It's an internal detailed of the build system and not user-facing. |
Co-authored-by: Erlend Egeberg Aasland <[email protected]>
Co-authored-by: Erlend Egeberg Aasland <[email protected]>
Signed-off-by: Christian Heimes [email protected]
https://bugs.python.org/issue45747