Skip to content

bpo-45747: Detect gdbm/dbm dependencies in configure (GH-29467) #29467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 10, 2021

Conversation

tiran
Copy link
Member

@tiran tiran commented Nov 8, 2021

Signed-off-by: Christian Heimes [email protected]

https://bugs.python.org/issue45747

@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 8, 2021
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @tiran for commit 73438e406438b95b299ddc37d4e8867053fbadfc 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 8, 2021
@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 8, 2021
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @tiran for commit dad6caa04c8a9ed153341a7ad644cb831f0d02ef 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 8, 2021
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments about configure.ac (I haven't looked at the setup.py changes yet)

Comment on lines +3128 to +3130
AC_CHECK_LIB([ndbm], [dbm_open])
LIBS="$LIBS_SAVE"
AC_CHECK_LIB([gdbm_compat], [dbm_open])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can fold these into:

Suggested change
AC_CHECK_LIB([ndbm], [dbm_open])
LIBS="$LIBS_SAVE"
AC_CHECK_LIB([gdbm_compat], [dbm_open])
AC_SEARCH_LIBS([dbm_open], [ndbm gdbm_compat])

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AC_SEARCH_LIBS() does not create HAVE_LIBFOO entries.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that's unfortunate.

tiran and others added 3 commits November 9, 2021 20:05
Co-authored-by: Erlend Egeberg Aasland <[email protected]>
Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@tiran tiran requested a review from erlend-aasland November 9, 2021 20:44
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is it worth it to document the USE_* defines in whatsnew?

@tiran
Copy link
Member Author

tiran commented Nov 10, 2021

LGTM. Is it worth it to document the USE_* defines in whatsnew?

It's an internal detailed of the build system and not user-facing.

@tiran tiran changed the title bpo-45747: Detect gdbm/dbm dependencies in configure bpo-45747: Detect gdbm/dbm dependencies in configure (GH-29467) Nov 10, 2021
@tiran tiran merged commit 0a9f695 into python:main Nov 10, 2021
@tiran tiran deleted the bpo-45747-dbm branch November 10, 2021 19:26
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
remykarem pushed a commit to remykarem/cpython that referenced this pull request Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants