Skip to content

bpo-46072: Document --enable-stats option. #30139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 16, 2021

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Dec 16, 2021

Also change the name of the script for parsing the stats as we want to handle all stats not just specialization.

https://bugs.python.org/issue46072

@@ -131,6 +131,17 @@ General Options

.. versionadded:: 3.11

.. cmdoption:: --enable-pystats
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

342b93f says --with-pystats. Which one is correct?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is. @tiran requested that it was changed to --enable-pystats

@@ -131,6 +131,17 @@ General Options

.. versionadded:: 3.11

.. cmdoption:: --enable-pystats

Turn on internal statistics gathering.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind to give a more more details? In the issue, you wrote: "Currently various parts of the VM gather stats: the GC, dicts, the bytecode interpreter, type lookup cache, etc.".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather not because, as it says, they are internal. We may well add or remove stats when we need them and this documentation will end up being a pain to maintain or just wrong.

@markshannon markshannon merged commit 4506bbe into python:main Dec 16, 2021
@markshannon markshannon deleted the doc-enable-stats branch September 26, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants