Skip to content

bpo-46347: Fix memory leak in PyEval_EvalCodeEx. #30546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2022
Merged

bpo-46347: Fix memory leak in PyEval_EvalCodeEx. #30546

merged 1 commit into from
Jan 11, 2022

Conversation

1st1
Copy link
Member

@1st1 1st1 commented Jan 11, 2022 •
edited by bedevere-bot
Loading

@tiran tiran added the needs backport to 3.10 only security fixes label Jan 11, 2022
@tiran
Copy link
Member

tiran commented Jan 11, 2022

Could you please add a news entry? 3.10 is affected, too.

@1st1
Copy link
Member Author

1st1 commented Jan 11, 2022

Could you please add a news entry? 3.10 is affected, too.

Yep, done

@elprans elprans mentioned this pull request Jan 11, 2022
Closed
tiran
tiran approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@1st1 1st1 merged commit 607d8a8 into main Jan 11, 2022
@1st1 1st1 deleted the fixmem branch January 11, 2022 22:25
@miss-islington
Copy link
Contributor

Thanks @1st1 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

@1st1: Please replace # with GH- in the commit message next time. Thanks!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 11, 2022
@1st1 @miss-islington
bpo-46347: Fix memory leak in PyEval_EvalCodeEx. (pythonGH-30546)
054a6f2 
First introduced in 0332e56
(cherry picked from commit 607d8a8)

Co-authored-by: Yury Selivanov <[email protected]>
@bedevere-bot
Copy link

GH-30549 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 11, 2022
miss-islington added a commit that referenced this pull request Jan 11, 2022
@miss-islington @1st1
bpo-46347: Fix memory leak in PyEval_EvalCodeEx. (GH-30546)
b1a94f1 
First introduced in 0332e56
(cherry picked from commit 607d8a8)

Co-authored-by: Yury Selivanov <[email protected]>
gpshead
gpshead reviewed Jan 12, 2022
View reviewed changes
Copy link
Member

@gpshead gpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

post-merge LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead gpshead left review comments

@tiran tiran tiran approved these changes

@vstinner vstinner Awaiting requested review from vstinner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@pablogsal pablogsal Awaiting requested review from pablogsal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@1st1 @tiran @miss-islington @bedevere-bot @gpshead @the-knights-who-say-ni