Skip to content

bpo-46417: Debug tp_subclasses crash #30791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

bpo-46417: Debug tp_subclasses crash #30791

wants to merge 1 commit into from

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jan 22, 2022 •
edited by bedevere-bot
Loading

  • _PyType_GetSubclasses() no longer holds a reference to
    tp_subclasses: its loop cannot modify tp_subclasses.
  • remove_subclass() now sets tp_subclasses to NULL if the dictionary
    becomes empty.

https://bugs.python.org/issue46417

@vstinner
bpo-46417: Debug tp_subclasses crash
a162e95 
* _PyType_GetSubclasses() no longer holds a reference to
  tp_subclasses: its loop cannot modify tp_subclasses.
* remove_subclass() now sets tp_subclasses to NULL if the dictionary
  becomes empty.
@vstinner vstinner closed this Jan 22, 2022
@vstinner vstinner reopened this Jan 22, 2022
@vstinner
Copy link
Member Author

I wrote a real fix instead: #30793

@vstinner vstinner closed this Jan 22, 2022
@vstinner vstinner deleted the debug_subclasses branch January 22, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon will be requested when the pull request is marked ready for review markshannon is a code owner

Assignees
No one assigned
Labels
awaiting core review skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @the-knights-who-say-ni @bedevere-bot