[3.10] bpo-46445, bpo-46519: Re-import typing.NewType

[Fidget-Spinner]

Partially reverts 65b88d5.

https://bugs.python.org/issue46445

Automerge-Triggered-By: GH:Fidget-Spinner

[gvanrossum]

The solution seems wrong though. The test goes out of its way to use typing.Foo everywhere.

[Fidget-Spinner]

The solution seems wrong though. The test goes out of its way to use typing.Foo everywhere.

That's on the main branch only right? On 3.10 it's still using plain NewType in many places.

https://github.com/Fidget-Spinner/cpython/blob/9d246cff2fa68301203552806919807b370ccfb1/Lib/test/test_typing.py#L3918
https://github.com/Fidget-Spinner/cpython/blob/9d246cff2fa68301203552806919807b370ccfb1/Lib/test/test_typing.py#L3970

I think we forgot to backport a fix to the tests, so they're now out of sync. I'll try to dig around and backport them, then we can remove this bandaid.

[Fidget-Spinner]

Git blame history goes to:
e89ef0a, then finally
96c4cbd

The last commit is the C accelerator for NewType in 3.11. Which would explain why on main it's importing things as self.module.NewType -- it needs to test both the Python and C version. 3.10 doesn't need that so it should be fine as-is. It was what we used previously after all 65b88d5.

[gvanrossum]

Okay. -- --Guido (mobile)