Skip to content

bpo-46576: bpo-46524: Disable compiler optimization within test_peg_generator. #31015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 2, 2022
Merged

bpo-46576: bpo-46524: Disable compiler optimization within test_peg_generator. #31015

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
efbb649
bpo-46576: Disable compiler optimization within test_peg_generator.
gpshead Jan 29, 2022
36044f3
incorporate #31017's win32 conditional and flags
gpshead Jan 30, 2022
42b989c
reword news
gpshead Jan 30, 2022
c4457db
Add -fno-lto
gpshead Jan 31, 2022
5b99059
Merge branch 'python:main' into faster_test_pegen
gpshead Feb 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Tests/2022-01-29-12-37-53.bpo-46576.-prRaV.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
test_peg_generator now disables compiler optimization when testing
compilation of its own C extensions to significantly speed up the
testing on non-debug builds of CPython.
8 changes: 8 additions & 0 deletions Tools/peg_generator/pegen/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import itertools
import pathlib
import shutil
import sys
import sysconfig
import tempfile
import tokenize
Expand Down Expand Up @@ -32,6 +33,7 @@ def compile_c_extension(
build_dir: Optional[str] = None,
verbose: bool = False,
keep_asserts: bool = True,
disable_optimization: bool = True, # Significant test_peg_generator speedup.
) -> str:
"""Compile the generated source for a parser generator into an extension module.

Expand Down Expand Up @@ -61,6 +63,12 @@ def compile_c_extension(
extra_link_args = get_extra_flags("LDFLAGS", "PY_LDFLAGS_NODIST")
if keep_asserts:
extra_compile_args.append("-UNDEBUG")
if disable_optimization:
if sys.platform == 'win32':
extra_compile_args.append("/Od")
extra_link_args.append("/LTCG:OFF")
else:
extra_compile_args.append("-O0")
extension = [
Extension(
extension_name,
Expand Down