GH-90915: Document that SystemExit doesn't trigger sys.excepthook #31357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was documented in `help(sys)`, but not in the main library documentation.
MaxwellDupre
approved these changes
Jun 14, 2022
slateny
reviewed
Oct 2, 2022
Doc/library/sys.rst
Outdated
| before the program exits. The handling of such top-level exceptions can be | ||
| customized by assigning another three-argument function to ``sys.excepthook``. | ||
| When an exception other than :exc:`SystemExit` is raised and uncaught, | ||
| the interpreter calls ``sys.excepthook`` with three arguments, the |
There was a problem hiding this comment.
Since the lines after the addition of SystemExit don't change, I'd say just make a new line even though it might be shorter than the rest so checking diff is easier
There was a problem hiding this comment.
Good idea, I've pushed to un-reflow this. (Also updated the branch from main.)
AA-Turner
approved these changes
Oct 3, 2022
kumaraditya303
changed the title
|
All commit authors signed the Contributor License Agreement. |
hugovk
added
needs backport to 3.11
This comment was marked as outdated.
This comment was marked as outdated.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 7, 2023
…ok (pythonGH-31357) (cherry picked from commit 1294fce) Co-authored-by: Colin Watson <[email protected]> Co-authored-by: Kumar Aditya <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
|
GH-109082 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 7, 2023
…ok (pythonGH-31357) (cherry picked from commit 1294fce) Co-authored-by: Colin Watson <[email protected]> Co-authored-by: Kumar Aditya <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
|
GH-109083 is a backport of this pull request to the 3.11 branch. |
hugovk
added a commit
that referenced
this pull request
Sep 7, 2023
…ook (GH-31357) (#109083) Co-authored-by: Colin Watson <[email protected]> Co-authored-by: Kumar Aditya <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
Yhg1s
pushed a commit
that referenced
this pull request
Sep 8, 2023
…ook (GH-31357) (#109082) GH-90915: Document that SystemExit doesn't trigger sys.excepthook (GH-31357) (cherry picked from commit 1294fce) Co-authored-by: Colin Watson <[email protected]> Co-authored-by: Kumar Aditya <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was documented in
help(sys), but not in the main librarydocumentation.
https://bugs.python.org/issue46759