Skip to content

bpo-20923 : [doc] Explain ConfigParser 'valid section name' #31359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

Vidhyavinu
Copy link
Contributor

@Vidhyavinu Vidhyavinu commented Feb 15, 2022

Updated the "Supported INI File Structure" with the details for legal section name: "By default, a legal section name can be any string that does not contain '\n' or ']'. To change this, see :attr:ConfigParser.SECTCRE."

https://bugs.python.org/issue20923

Updated the "Supported INI File Structure" with the details for legal section name: "By default,  a legal section name can be any string that does not contain '\\n' or ']'.  
To change this, see :attr:`ConfigParser.SECTCRE`."
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@Vidhyavinu

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Feb 15, 2022
.. [1] Config parsers allow for heavy customization. If you are interested in
changing the behaviour outlined by the footnote reference, consult the
`Customizing Parser Behaviour`_ section.
:mod:`configparser` --- Configuration file parser
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff looks as if you changed everything in the file - is there a whitespace issue?

It should show only what you changed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. There is some whitespace issue. So I again tried upstreaming from the main branch and redo the modification. But still it shows the same.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a comparison report with BeyondCompare. This will help to locate the changes done as a part of this commit:
Diff1
Diff2

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to sort this out in the PR. It won't be merged as it is now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the file in my last commit.
Thanks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the same as before. Look at the "files changed" tab on the PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing this pull request and creating new one. Sorry for the inconvenience.

New one: #31413

@Vidhyavinu
Copy link
Contributor Author

Vidhyavinu commented Feb 15, 2022 via email

@Vidhyavinu Vidhyavinu closed this Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review docs Documentation in the Doc dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants