bpo-46887: Work around clang MSAN bug on stat()/fstat() #31633
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initialize the input "struct stat" buffer with zeros to prevent a false alarm on calling stat() and fstat().
| @@ -2484,6 +2484,12 @@ posix_do_stat(PyObject *module, const char *function_name, path_t *path, | |||
| STRUCT_STAT st; | |||
| int result; | |||
|
|
|||
| # if __has_feature(memory_sanitizer) | |||
There was a problem hiding this comment.
It requires a check if __has_feature is defined
There was a problem hiding this comment.
pyport.h defines _Py_MEMORY_SANITIZER for us, taking care of all of the compiler/platform conditionals around this.
|
I don't want to merge this PR, I would prefer to wait until llvm/llvm-project#54131 is fixed. Problem: LLVM told me that LLVM is fined, it's a Fedora issue. Ah. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initialize the input "struct stat" buffer with zeros to prevent a
false alarm on calling stat() and fstat().
https://bugs.python.org/issue46887