Skip to content

bpo-31564: NewType can subclass NewType #3696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2017
Merged

Conversation

topper-123
Copy link
Contributor

@topper-123 topper-123 commented Sep 22, 2017

It has become possible to create a NewType from an existing NewType, see python/mypy#3465 and python/peps#271.

This is a small update to the documentation as a concequence of the above change.

I've logged this as an issue at #bpo-31564 as per @Mariatta request.

https://bugs.python.org/issue31564

It has become possible to create a ``NewType`` from an existing  ``NewType``, see python/mypy#3465 and python/peps#271.

This is a small update to the documentation as a concequence of the above change.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@topper-123
Copy link
Contributor Author

I've signed the CLA now.

@Mariatta Mariatta added needs backport to 3.6 docs Documentation in the Doc dir skip news labels Sep 23, 2017
@Mariatta
Copy link
Member

This seems good, but I'm not the typing expert..
@ilevkivskyi Maybe you can take another look? Thanks :)

@Mariatta
Copy link
Member

No news entry is needed, but I think we should at least have an issue in the bug tracker. @topper-123 can you create an issue, and then add the bpo number to this PR?
Thanks.

Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me.

@topper-123 topper-123 changed the title DOCS: NewType can subclass NewType bpo-31564: NewType can subclass NewType Sep 23, 2017
@Mariatta Mariatta merged commit 039b25d into python:master Sep 24, 2017
@miss-islington
Copy link
Contributor

Thanks @topper-123 for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-3715 is a backport of this pull request to the 3.6 branch.

@Mariatta
Copy link
Member

Thanks for the review @ilevkivskyi.
@topper-123 thanks and congrats on your first contribution to CPython 🌮

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants