-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
bpo-31564: NewType can subclass NewType #3696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It has become possible to create a ``NewType`` from an existing ``NewType``, see python/mypy#3465 and python/peps#271. This is a small update to the documentation as a concequence of the above change.
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
I've signed the CLA now. |
This seems good, but I'm not the typing expert.. |
No news entry is needed, but I think we should at least have an issue in the bug tracker. @topper-123 can you create an issue, and then add the bpo number to this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good to me.
Thanks @topper-123 for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6. |
GH-3715 is a backport of this pull request to the 3.6 branch. |
Thanks for the review @ilevkivskyi. |
It has become possible to create a
NewType
from an existingNewType
, see python/mypy#3465 and python/peps#271.This is a small update to the documentation as a concequence of the above change.
I've logged this as an issue at #bpo-31564 as per @Mariatta request.
https://bugs.python.org/issue31564