bpo-32126: Skip asyncio test when sem_open() is not functional #4559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asvetlov
reviewed
Nov 25, 2017
Lib/test/test_asyncio/test_events.py
Outdated
| @@ -2156,6 +2156,8 @@ def tearDown(self): | |||
| super().tearDown() | |||
|
|
|||
| def test_get_event_loop_new_process(self): | |||
| # Skip the test if the sem_open() implementation is broken. | |||
| support.import_module('multiprocessing.synchronize') | |||
There was a problem hiding this comment.
The check is very non-obvious.
Don't how to make it more verbose and explicit.
If it's impossible -- I can live with it.
There was a problem hiding this comment.
The ProcessPoolExecutor uses the multiprocessing (mp) module. The mp module is not functional when the mp.synchronize module cannot be imported and all the mp tests are skipped in that case. So we use here the same idiom used to skip the mp tests (i.e. test.support.import_module('multiprocessing.synchronize')) to skip this test when the platform sem_open implementation is broken or missing.
What about replacing the comment with:
Issue bpo-32126: The multiprocessing module used by ProcessPoolExecutor
is not functional when the multiprocessing.synchronize module cannot be imported.
There was a problem hiding this comment.
New comment text is perfect!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue32126