Skip to content

bpo-32226: Make __class_getitem__ an automatic class method. #5098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2018
Merged

bpo-32226: Make __class_getitem__ an automatic class method. #5098

merged 1 commit into from
Jan 4, 2018

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jan 4, 2018 •
edited by bedevere-bot
Loading

@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Jan 4, 2018
ilevkivskyi
ilevkivskyi approved these changes Jan 4, 2018
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for implementing this!

I wanted to do this, but unfortunately didn't have time. I will update the typing part accordingly (there is only one little place that needs to be updated).

@serhiy-storchaka serhiy-storchaka merged commit ce5b0e9 into python:master Jan 4, 2018
@serhiy-storchaka serhiy-storchaka deleted the __class_getitem__-classmethod branch January 4, 2018 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@serhiy-storchaka @ilevkivskyi @the-knights-who-say-ni @bedevere-bot