Skip to content

bpo-17611. Move unwinding of stack for "pseudo exceptions" from interpreter to compiler. (alt) #5143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 77 commits into from
Closed

bpo-17611. Move unwinding of stack for "pseudo exceptions" from interpreter to compiler. (alt) #5143

wants to merge 77 commits into from

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jan 9, 2018 •
edited by bedevere-bot
Loading

An alternative to #5006 that restores SETUP_EXCEPT and gets rid of the new opcode BEGIN_FINALLY.

SETUP_FINALLY, SETUP_WITH and SETUP_ASYNC_WITH now push NULL on the stack instead.

https://bugs.python.org/issue17611

pitrou and others added 30 commits December 24, 2017 15:43
@pitrou @serhiy-storchaka
bpo-17611: Move unwinding of stack from interpreter to compiler
2315076
@pitrou @serhiy-storchaka
Cleanup
b160900
@pitrou @serhiy-storchaka
Improve stack size calculation for SETUP_{EXCEPT,FINALLY}
9833631
@pitrou @serhiy-storchaka
Update frozen importlib
9116fb8
@pitrou @serhiy-storchaka
Remove useless code
5b3796e
@pitrou @serhiy-storchaka
Don't predict FOR_ITER as it breaks tracing without computed gotos
77caab0
@pitrou @serhiy-storchaka
Remove dead code and fix tracing tests
9fffb61
@pitrou @serhiy-storchaka
Fix test_dis
5fe5e1b
@pitrou @serhiy-storchaka
Add JUMP_FINALLY to avoid finally block duplication
a93f2e2
@pitrou @serhiy-storchaka
Remove finally block duplication
b007b1c
@pitrou @serhiy-storchaka
More precise computation of code object stack size
0bcf8a7
@pitrou @serhiy-storchaka
JUMP_FINALLY pushes 6 values to be consistent with the effect of an e…
eecf02f 
…xception
@pitrou @serhiy-storchaka
Exact stack size computation by popping stale exception state in RERAISE
64225ce
@pitrou @serhiy-storchaka
Remove the now pointless POP_MANY
04e055e
@pitrou @serhiy-storchaka
Add comment for RERAISE
a3e1b80
@pitrou @serhiy-storchaka
Remove JUMP_FINALLY
a049635
@pitrou @serhiy-storchaka
Remove last block duplication
0741d02
@pitrou @serhiy-storchaka
Get rid of END_ITER
5493616
@pitrou @serhiy-storchaka
Fix comments in frameobject.c
5c68acf
@pitrou @serhiy-storchaka
Add stack size tests
2d41c17
@serhiy-storchaka
Fix test_dis.
afc2235
@serhiy-storchaka
Simplify handling of 'for' loops in frame_setlineno() and fix it for …
00a6681 
…long opargs.
@serhiy-storchaka
Do not duplicate the finally block.
f8cc274
@serhiy-storchaka
Refactor the frame unwinding code.
160ce37
@serhiy-storchaka
Refactoring and optimizations in the compiler.
b3b3250
@serhiy-storchaka
Fix frame_setlineno().
e3f5099
@serhiy-storchaka
Rename PUSH_NO_EXCEPT to BEGIN_FINALLY.
d8dd38d
@serhiy-storchaka
Restore SETUP_WITH and SETUP_ASYNC_WITH.
f1d0bc9
@serhiy-storchaka
Fix stack depth calculation.
84c6400
@serhiy-storchaka
Remove SETUP_EXCEPT.
35bd61b
@serhiy-storchaka
Clarify the use case of POP_FINALLY.
4ca9831
@serhiy-storchaka
bpo-24340: Fix estimation of the code stack size.
e34670a
@serhiy-storchaka
Add new tests for stack effect (ported from python#5076).
42b50d1
@serhiy-storchaka
Add comments.
3d04b53
@serhiy-storchaka
Simplify the algorithm, add comments and asserts.
4b1697d
@serhiy-storchaka
Merge branch 'master' into stack-size
dc25d14
@serhiy-storchaka
Merge branch 'master' into unwind_stack
8a327cb
@serhiy-storchaka
Merge branch 'stack-size' into unwind_stack
4afb870
@serhiy-storchaka
Fix stack effect computation.
4d81d0d
@serhiy-storchaka
Update comments and docs in responce to the review.
edde33a
@serhiy-storchaka
Add more tests.
44c7d39
@serhiy-storchaka
Merge branch 'stack-size' into unwind_stack_new
8dcb17f
@serhiy-storchaka
Add more comments.
0317c9d
@serhiy-storchaka
Define all stack effects in a single place.
7a33146
@serhiy-storchaka
Make stack_effect() static.
68e35bb
@serhiy-storchaka
Add braces for PEP 7.
6056bc7
@serhiy-storchaka
Merge branch 'master' into stack-size
44e1e1e
@serhiy-storchaka
Merge branch 'master' into unwind_stack
04647d6
@serhiy-storchaka
Merge branch 'stack-size' into unwind_stack
6d5c333
@serhiy-storchaka
Add braces for PEP 7.
660a117
@serhiy-storchaka
Merge branch 'master' into unwind_stack
a03d212
@serhiy-storchaka
Merge branch 'master' into unwind_stack
ff0448f
@serhiy-storchaka
Simplify WITH_CLEANUP_START. It is never called after CALL_FINALLY.
bd39e0a
@serhiy-storchaka
Restore SETUP_EXCEPT.
fe25870
@serhiy-storchaka
Remove BEGIN_FINALLY. Change SETUP_FINALLY, SETUP_WITH and SETUP_ASYN…
db8f2a2 
…C_WITH.
@serhiy-storchaka serhiy-storchaka requested a review from 1st1 as a code owner January 9, 2018 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou Awaiting requested review from pitrou

@1st1 1st1 Awaiting requested review from 1st1

Assignees

No one assigned

Labels

awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@serhiy-storchaka @the-knights-who-say-ni @bedevere-bot @pitrou