Skip to content

bpo-32493: Fix uuid.uuid1() on FreeBSD. #7098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented May 24, 2018

@vstinner
Copy link
Member

On FreeBSD, there are uuid_enc_le() and uuid_enc_be() functions to encode a uuid_t type into an octet stream in little-endian and big-endian byte-order, respectively.
https://www.freebsd.org/cgi/man.cgi?query=uuid_create

I don't think if it would help, these functions don't seem to be portable.

@serhiy-storchaka
Copy link
Member Author

Good point Victor! These functions are supported on all three open BSD systems, and it would be more convenient to just use them. But it is not part of the DCE RPC API and is not supported on AIX. Actually I don't know whether on AIX uuid_create() creates platform-dependent or big-endian representation. If the latter, than this PR is incorrect, and we need to use uuid_enc_be() on *BSD only.

@ned-deily
Copy link
Member

Can we just correctly fix the *BSDs while leaving the existing AIX code as is for 3.7.0? We consider FreeBSD to be a atable platform whereas AIX is more in the "best effort" category.

@serhiy-storchaka
Copy link
Member Author

See an alternate solution in #7099.

@vstinner
Copy link
Member

I prefer to handle endianness in _uuid, so I chose to merge the alternative PR #7099.

@vstinner vstinner closed this May 24, 2018
@serhiy-storchaka serhiy-storchaka deleted the uuid-create-freebsd branch May 24, 2018 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants